https://github.com/flash1729 created https://github.com/llvm/llvm-project/pull/183801
## Description Fix minor typos and incorrect comments in the APINotes subsystem (No functional code is modified) ## Changes Made - **`APINotesReader.h`** — Fixed `member buffer` → `memory buffer` in the `Create()` doc comment (`Create()` takes a `llvm::MemoryBuffer`) - **`APINotesFormat.h`** — Corrected the file header comment which incorrectly referred to `APINotesWriter.h` instead of `APINotesFormat.h` - **`APINotesYAMLCompiler.cpp`** — Fixed `it's` → `its` (possessive, not a contraction) - **`SemaAPINotes.cpp`** — Fixed `collection` → `collecting` and added a missing `to` in `defer to the client to select` ## Motivation First contribution to LLVM, aimed at getting familiar with the contributing workflow. >From 85eb3ba5ee3d1f8b15a896bbcf6f4d2626eafec7 Mon Sep 17 00:00:00 2001 From: flash1729 <[email protected]> Date: Wed, 18 Feb 2026 07:14:48 +0530 Subject: [PATCH] [APINotes][NFC] Fix typos and header comment errors --- clang/include/clang/APINotes/APINotesReader.h | 2 +- clang/lib/APINotes/APINotesFormat.h | 2 +- clang/lib/APINotes/APINotesYAMLCompiler.cpp | 2 +- clang/lib/Sema/SemaAPINotes.cpp | 4 ++-- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/clang/include/clang/APINotes/APINotesReader.h b/clang/include/clang/APINotes/APINotesReader.h index baf6334064024..0078de5dbc584 100644 --- a/clang/include/clang/APINotes/APINotesReader.h +++ b/clang/include/clang/APINotes/APINotesReader.h @@ -33,7 +33,7 @@ class APINotesReader { llvm::VersionTuple SwiftVersion, bool &Failed); public: - /// Create a new API notes reader from the given member buffer, which + /// Create a new API notes reader from the given memory buffer, which /// contains the contents of a binary API notes file. /// /// \returns the new API notes reader, or null if an error occurred. diff --git a/clang/lib/APINotes/APINotesFormat.h b/clang/lib/APINotes/APINotesFormat.h index bb423ccb2bfaf..c094a851bc49d 100644 --- a/clang/lib/APINotes/APINotesFormat.h +++ b/clang/lib/APINotes/APINotesFormat.h @@ -1,4 +1,4 @@ -//===-- APINotesWriter.h - API Notes Writer ---------------------*- C++ -*-===// +//===-- APINotesFormat.h - API Notes Format ---------------------*- C++ -*-===// // // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // See https://llvm.org/LICENSE.txt for license information. diff --git a/clang/lib/APINotes/APINotesYAMLCompiler.cpp b/clang/lib/APINotes/APINotesYAMLCompiler.cpp index 3be528feb325e..3b82fdda68af1 100644 --- a/clang/lib/APINotes/APINotesYAMLCompiler.cpp +++ b/clang/lib/APINotes/APINotesYAMLCompiler.cpp @@ -103,7 +103,7 @@ template <> struct ScalarEnumerationTraits<NullabilityKind> { IO.enumCase(NK, "Optional", NullabilityKind::Nullable); IO.enumCase(NK, "Unspecified", NullabilityKind::Unspecified); IO.enumCase(NK, "NullableResult", NullabilityKind::NullableResult); - // TODO: Mapping this to it's own value would allow for better cross + // TODO: Mapping this to its own value would allow for better cross // checking. Also the default should be Unknown. IO.enumCase(NK, "Scalar", NullabilityKind::Unspecified); diff --git a/clang/lib/Sema/SemaAPINotes.cpp b/clang/lib/Sema/SemaAPINotes.cpp index 12929895b3789..a48edbbe027a4 100644 --- a/clang/lib/Sema/SemaAPINotes.cpp +++ b/clang/lib/Sema/SemaAPINotes.cpp @@ -911,8 +911,8 @@ static void ProcessVersionedAPINotes( auto Active = (i == Selected) ? IsActive_t::Active : IsActive_t::Inactive; auto Replacement = IsSubstitution_t::Original; - // When collection all APINotes as version-independent, - // capture all as inactive and defer to the client select the + // When collecting all APINotes as version-independent, + // capture all as inactive and defer to the client to select the // right one. if (S.captureSwiftVersionIndependentAPINotes()) { Active = IsActive_t::Inactive; _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
