kikairoya wrote:

Ugh... This change produces a ton of warnings for libc++.

```
(snip)
/k/llvm/build/runtime/include/c++/v1/__numeric/saturation_arithmetic.h:106:1: 
warning: '__exclude_from_explicit_instantiation__' attribute ignored on a 
non-member declaration [-Wignored-attributes]
  106 | _LIBCPP_HIDE_FROM_ABI constexpr _Rp __saturate_cast(_Tp __x) noexcept {
      | ^
/k/llvm/build/runtime/include/c++/v1/__configuration/attributes.h:211:20: note: 
expanded from macro '_LIBCPP_HIDE_FROM_ABI'
  211 |     _LIBCPP_HIDDEN _LIBCPP_EXCLUDE_FROM_EXPLICIT_INSTANTIATION          
                                               \
      |                    ^
/k/llvm/build/runtime/include/c++/v1/__configuration/attributes.h:119:70: note: 
expanded from macro '_LIBCPP_EXCLUDE_FROM_EXPLICIT_INSTANTIATION'
  119 | #  define _LIBCPP_EXCLUDE_FROM_EXPLICIT_INSTANTIATION 
__attribute__((__exclude_from_explicit_instantiation__))
      |                                                                      ^
1905 warnings generated.
```

We should just drop the attribute silently, without any warnings.

https://github.com/llvm/llvm-project/pull/183514
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to