nikic wrote: It's sometimes hard to read intent when it's not explicitly stated. In this case the PR was already approved, and the questions answered without further response, so I think it was fairly reasonable to assume that there aren't further concerns.
To avoid misunderstandings, especially for PRs that already have approvals, I'd recommend explicitly writing something like "Please wait for me to review this as well" to make it clear that the PR shouldn't be merged just yet. https://github.com/llvm/llvm-project/pull/178359 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
