================
@@ -188,9 +193,10 @@ dependencies::initVFSForByNameScanning(
InMemoryFS->setCurrentWorkingDirectory(WorkingDirectory);
SmallString<128> FakeInputPath;
// TODO: We should retry the creation if the path already exists.
- llvm::sys::fs::createUniquePath(ModuleName + "-%%%%%%%%.input",
FakeInputPath,
+ llvm::sys::fs::createUniquePath("module-import-%%%%.input", FakeInputPath,
----------------
qiongsiwu wrote:
Yeah I think you are correct that the uniqueness is not a correctness
requirement. We don't even need the 4 character string in the end. The reason I
am keeping the uniqueness is that the same file is used for all names scanned
by the same dependency scanning worker (hence the same thread). When we see
such diagnostics produced, we will know through the unique paths to know if
they come from the same worker or not. If we don't think this identification is
necessary I will completely remove the unique identifier from the path.
https://github.com/llvm/llvm-project/pull/183396
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
