================ @@ -13279,6 +13284,18 @@ def err_sycl_entry_point_return_type : Error< def err_sycl_entry_point_deduced_return_type : Error< "the %0 attribute only applies to functions with a non-deduced 'void' return" " type">; +def note_sycl_runtime_defect : Note< + "this error is due to a defect in SYCL runtime header files; please report" ---------------- tahonermann wrote:
I would be happy to remove the note. I added it because the idea of adding it came up in discussion with @AaronBallman and he seemed to favor it at the time. His concerns about the new diagnostic (example below) were reduced by the revelation that only authors of a SYCL run-time library should ever see this diagnostic (and only when the SYCL headers are not correctly implemented). Since the call to `sycl_kernel_launch` is implicit and its arguments are not necessarily easy to determine from looking at the original source code, these details make it easier to replicate reported problems and debug them (e.g., the SYCL run-time maintainer can test calling their `sycl_kernel_launch` function directly rather than having to reproduce details of the SYCL kernel definition that originally triggered the error). ``` error: no matching function for call to 'sycl_kernel_launch' note: in implicit call to 'sycl_kernel_launch' with template argument 'BADKN<5>' and function arguments (lvalue of type 'const char[12]', xvalue of type 'BADKT<5>', xvalue of type 'int') required here ``` https://github.com/llvm/llvm-project/pull/152403 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
