aankit-ca wrote: > > @quic-akaryaki clang/lib/Basic/Targets/Hexagon.cpp suggests that supported > > architectures are: > > V5, V55, V60, V62, V65, V66, V67, V67t, V68, V69, V71, V71t, V73, V75, V79, > > V81 > > I'm fine removing the comments from the closing guards though. > > **HVX_ARCH** cannot be less than 60, though? This condition is always true.
Okay, you are right. They guard is on the hvx version which should be defined only on v60+. > > > @quic-akaryaki clang/lib/Basic/Targets/Hexagon.cpp suggests that > > > supported architectures are: > > > V5, V55, V60, V62, V65, V66, V67, V67t, V68, V69, V71, V71t, V73, V75, > > > V79, V81 > > > I'm fine removing the comments from the closing guards though. > > > > > > **HVX_ARCH** cannot be less than 60, though? This condition is always true. > > Even if -mno-hvx? > > Is there another guard covering that? This file gets directly included > sometimes IIRC. Yes, there is a __HVX___ guard at the top of the file. With -mno-hvx __HVX__ would be false. https://github.com/llvm/llvm-project/pull/184422 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
