================
@@ -797,6 +797,22 @@ CIRGenModule::getOrCreateCIRGlobal(StringRef mangledName,
mlir::Type ty,
"external const declaration with initializer");
}
+ // TODO(cir): if this method is used to handle functions we must have
+ // something closer to GlobalValue::isDeclaration instead of checking for
+ // initializer.
+ if (gv.isDeclaration()) {
+ // TODO(cir): set target attributes
+
+ // External HIP managed variables needed to be recorded for transformation
+ // in both device and host compilations.
+ // External HIP managed variables needed to be recorded for transformation
+ // in both device and host compilations.
+ if (getLangOpts().CUDA && d && d->hasAttr<HIPManagedAttr>() &&
+ d->hasExternalStorage())
+ llvm_unreachable("NYI");
+ }
+
+ // TODO(cir): address space cast when needed for DAddrSpace.
----------------
andykaylor wrote:
```suggestion
assert(!cir::MissingFeatures::addressSpaces());
```
https://github.com/llvm/llvm-project/pull/184248
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
