banach-space wrote:

Thanks!

> The change has been tested via clang-check and check-clang which returns no 
> error nor warnings

Did you test this with ClangIR enabled? `-DCLANG_ENABLE_CIR=True` Also, which 
header files are generated from those *.def files and are those affected? If 
yes, how?

> I appreciate the review. Most of the .td file was translated using the python 
> script tools.py which I wrote in this repo - 
> https://github.com/moodytongytong/random-python-script

The script should be included in the submission, perhaps as a comment. That's 
primarily to preserve the history and for downstream users that have made local 
modifications to those files.

I will try to take a closer look tomorrow.

https://github.com/llvm/llvm-project/pull/179692
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to