llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-analysis Author: Rohan Jacob-Rao (rohanjr) <details> <summary>Changes</summary> This prevents a crash if the range text is invalid. --- Full diff: https://github.com/llvm/llvm-project/pull/184867.diff 1 Files Affected: - (modified) clang/lib/Analysis/FixitUtil.cpp (+6-2) ``````````diff diff --git a/clang/lib/Analysis/FixitUtil.cpp b/clang/lib/Analysis/FixitUtil.cpp index 4ac3f3acd8c62..ec1924f9c3e10 100644 --- a/clang/lib/Analysis/FixitUtil.cpp +++ b/clang/lib/Analysis/FixitUtil.cpp @@ -89,8 +89,12 @@ clang::getPointeeTypeText(const DeclaratorDecl *VD, const SourceManager &SM, // `PteTy` via source ranges. *QualifiersToAppend = PteTy.getQualifiers(); } - return getRangeText({PteTyLoc.getBeginLoc(), PteEndOfTokenLoc}, SM, LangOpts) - ->str(); + + std::optional<StringRef> RangeText = + getRangeText({PteTyLoc.getBeginLoc(), PteEndOfTokenLoc}, SM, LangOpts); + if (!RangeText) + return std::nullopt; + return RangeText->str(); } // returns text of pointee to pointee (T*&) `````````` </details> https://github.com/llvm/llvm-project/pull/184867 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
