================
@@ -797,6 +797,22 @@ CIRGenModule::getOrCreateCIRGlobal(StringRef mangledName, 
mlir::Type ty,
                "external const declaration with initializer");
   }
 
+  // TODO(cir): if this method is used to handle functions we must have
----------------
ZakyHermawan wrote:

This is just stuff from 
[incubator](https://github.com/llvm/clangir/blob/main/clang/lib/CIR/CodeGen/CIRGenModule.cpp#L1289).
I will remove it, because getOrCreateCIRGlobal is specifically for global 
variables.

https://github.com/llvm/llvm-project/pull/184248
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to