hans accepted this revision. hans added a comment. This revision is now accepted and ready to land.
Thanks! Looks good to me. ================ Comment at: clang/lib/Driver/ToolChain.cpp:308 + if (TC.getArch() == llvm::Triple::x86 && Triple.isAndroid()) + return "i686"; ---------------- Maybe add a comment here explaining that this is for historical reasons. Or in the cmake file below (or both). https://reviews.llvm.org/D37278 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
