aaron.ballman accepted this revision. aaron.ballman added a comment. In https://reviews.llvm.org/D36272#856857, @erichkeane wrote:
> In https://reviews.llvm.org/D36272#856849, @anatol.pomozov wrote: > > > > if we corrected the attribute spelling to be GCC instead of GNU and added > > > some documentation to the attribute > > > > These are great suggestions! But I think it makes more sense to have a > > separate change for it as it orthogonal to what I am trying to do here. > > Having separate commits for independent changes is better as it makes > > things like bisecting and rollbacks easier. > > > I tend to agree, however I suspect Aaron really wants it done. Any chance > you could submit a review to make that change? *Please* :) I agree that a follow-up patch is totally fine for this. If (either of) you want to do the patch, that'd be fantastic! If you don't feel like doing the patch, that's also fine (I may get around to it someday myself). https://reviews.llvm.org/D36272 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
