[STL] > I can't check in copies of `cl.exe` and `link.exe` (the former's version is > inspected, so it can't just be a dummy file). > I'm happy without upstream tests for this logic. In the long run, I hope that > we can eliminate this internal directory structure and make it identical to > the released directory structure.
[David Blaikie] > Version as in file metadata, or version as in "cl -v" printed output or the > like? > If it's file metadata (such that Clang can discover it without having to run > the binary on a test machine) might be worth making a dummy file with just > the version metadata in it. > But yeah *shrug* your call Looks like it's just the metadata, so a dummy file would be possible (Don pointed out how the version metadata is created - I thought it was some complicated process, but it's not). However, I'm not planning to write tests at the moment - I see that it is possible but there's a big leap from that to knowing how to actually write them, and I have to go back to working on C++17 features. If the logic for DevDiv-internal paths breaks, I'll deal with it then. Thanks, STL _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
