ilya-biryukov added inline comments.

================
Comment at: clangd/ClangdUnit.cpp:337
+    // Fill in the kind field of the CompletionItem.
+    Item.kind = getKind(Result.CursorKind);
+
----------------
ilya-biryukov wrote:
> ilya-biryukov wrote:
> > Could we also set `Item.filterText` to completion item name?
> > So that various pieces of function signature would not match on user input.
> After some investigation: `CK_TypedText` chunks are exactly the things that 
> should go into `filterText`.
> Also, VSCode seems to ignore `filterText` right now, but that's certainly a 
> bug in VSCode, I still propose to set `filterText` properly.
Sorry for confusion, after updating VSCode to the last version, `filterText` 
works just fine.


https://reviews.llvm.org/D37101



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to