rsmith requested changes to this revision.
rsmith added a comment.
This revision now requires changes to proceed.

It's not reasonable for external users of Clang's AST to infer deep meaning 
from the "invalid" flag. It's simply a mechanism by which we (a) limit the 
amount of follow-on diagnostics, and (b) somewhat weaken our AST invariants in 
the presence of invalid code; it is an implementation detail and subject to 
change at any time. (If a node is not marked invalid, that does not imply the 
corresponding source code is valid.)

If you would like a system to hook into the start and end of creating a 
function (so you can install your own error trap from an external user of 
Sema), that would seem like something we could reasonably support.


https://reviews.llvm.org/D37381



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to