hintonda added a comment. In https://reviews.llvm.org/D35533#862798, @minseong.kim wrote:
> Hi~ @hintonda, > > Using using find_first_existing_file in ADDLLVM.cmake solves the cases with > repo in conjunction with https://reviews.llvm.org/D35532. However, I am not > sure it can handle @modocache's git submodule cases > (https://reviews.llvm.org/D34955). > > @modocache, could you please check removing find_first_existing_file and > find_first_existing_vc_file from lib/Basic/CMakeLists.txt solves git > submodule cases ? > > If so, I will remove them from clang's cmake to make one unified place for > the same functionality. Essentially, I think having a single version that works in all cases would be best. I really haven't looked into it, but would it make sense to incorporate @modocache's module changes into the version in AddLLVM.cmake? https://reviews.llvm.org/D35533 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
