kristof.beyls added inline comments.
================ Comment at: lib/Driver/ToolChains/Arch/ARM.cpp:137 + const Driver &D = TC.getDriver(); + arm::ReadTPMode ThreadPointer = ReadTPMode::Invalid; + if (Arg *A = ---------------- With the new version of the code, there's no need to have a ThreadPointer variable declared here; it can be declared inside the if statement below instead. ================ Comment at: lib/Driver/ToolChains/Arch/ARM.cpp:149-150 + else + D.Diag(diag::err_drv_invalid_mtp) << A->getAsString(Args); + } + return ReadTPMode::Soft; ---------------- a return ReadTPMode::Invalid is missing here. https://reviews.llvm.org/D34878 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
