zwuis wrote:
Generally looks good, but I'm not familiar with this part of code.
> Example:
>
> ```c++
> if (isDeprecatedAlias("performance-prefer-single-char-overloads")) {
> diag(Literal->getBeginLoc(),
> "performance-faster-string-find is deprecated and will be removed in
> "
> "a future release; consider using "
> "performance-prefer-single-char-overloads",
> DiagnosticIDs::Note);
> }
> ```
It would be better to call `configurationDiag` instead of `diag`.
https://github.com/llvm/llvm-project/pull/189522
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
