johannes added inline comments.

================
Comment at: include/clang/AST/RecursiveASTVisitor.h:334
+    case OO_Arrow:
+    case OO_Call:
+    case OO_Subscript:
----------------
klimek wrote:
> Why do we need to swap for calls?
The idea is that the opening parenthesis/bracket  comes after the caller, for 
example in this call with two arguments.

```
    `-CXXOperatorCallExpr
      |-ImplicitCastExpr
      | `-DeclRefExpr operator()
      |-DeclRefExpr caller
      |-IntegerLiteral
      `-IntegerLiteral
```

 Of course we fail to capture the fact that there is also a closing parenthesis 
or bracket. So this is no perfect solution.


https://reviews.llvm.org/D37663



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D37663: [... Johannes Altmanninger via Phabricator via cfe-commits
    • [PATCH] D376... Manuel Klimek via Phabricator via cfe-commits
    • [PATCH] D376... Johannes Altmanninger via Phabricator via cfe-commits
    • [PATCH] D376... Richard Smith - zygoloid via Phabricator via cfe-commits
    • [PATCH] D376... Johannes Altmanninger via Phabricator via cfe-commits
    • [PATCH] D376... Johannes Altmanninger via Phabricator via cfe-commits

Reply via email to