https://github.com/AaronBallman commented:

Thank you for working on this! A few thoughts.

1) Clang's documentation should consistently be in .rst files; there have been 
a few things moved to `.md` but those changes have been questioned enough that 
we should not use it as precedent for adding more .md files.
2) It's not quite clear to me what the long-term direction is. e.g., in Clang, 
we tend to use tablegen to generate documentation (attributes, command line 
options, etc) so that we can generate C++ code for the implementation which is 
tied to the documentation we generate. Are you expecting to follow a similar 
direction for CIR? I ask because I don't think we want code generators in 
tablegen *and* python if we can avoid it.

https://github.com/llvm/llvm-project/pull/190354
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to