================
@@ -694,7 +694,8 @@ class ScalarExprEmitter : public 
StmtVisitor<ScalarExprEmitter, mlir::Value> {
         return {};
       }
 
-      if (mlir::isa<cir::SingleType, cir::DoubleType>(value.getType())) {
+      if (mlir::isa<cir::SingleType, cir::DoubleType, cir::LongDoubleType>(
+              value.getType())) {
----------------
andykaylor wrote:

```suggestion
      if (cir::isAnyFloatingPointType(value.getType())) {
```
It's not clear to me why we're checking the type here at all. I see that half 
requires special handling if the target doesn't have native support for it. Do 
we need something like that for FP80 and FP128 or does Sema check that?

https://github.com/llvm/llvm-project/pull/190812
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to