EricWF requested changes to this revision. EricWF added a comment. This revision now requires changes to proceed.
I agree with the general consensus that we should only make this change if it's significantly faster, and only after we have a test that demonstrates this. Unfortunately I don't recall exactly why I wrote that TODO in the first place, but I'm sure I meant changing `__state_`, and not the lock. I suspect it had to do with http://llvm.org/PR24692 . ================ Comment at: include/future:538 + + mutable class __spin_lock + { ---------------- It seems this change is ABI breaking, since `mutex` and `__spin_lock` don't have the same layout. The change will need to be guarded behind a `_LIBCPP_ABI_FOO` macro. See `__config` for examples. https://reviews.llvm.org/D37677 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
