AaronBallman wrote: > > > Since CIR is opt-in behind a CMake flag CLANG_ENABLE_CIR, the > > > CIRLangRef.rst page is generated only when CIR is included in the build. > > > > > > Hmmm, I can see why but this still caught be my surprise. To me, > > documentation is a separate thing from enabling support for CIR at all so I > > was not expecting `CLANG_ENABLE_CIR` to mean no CIR docs get built. So I > > think I'd be fine if the page was generated always regardless, if that > > happened to be easier to support. > > Yeah I agree that this doesn't sound very right. I'm not quite sure at this > point if it's easy to support the generation of CIR documents regardless of > `CLANG_ENABLE_CIR`, but one obvious caveat is that now we need to rely on > MLIR even if CIR is disabled, because we need `mlir-tblgen` to generate the > documents.
Yeah, I think it is likely more reasonable for there to be no CIR docs when `CLANG_ENABLE_CIR` is false than it is to require rebuilding MLIR when `CLANG_ENABLE_CIR` is false. Hopefully we get to the point where `CLANG_ENABLE_CIR` isn't a thing any more at some point. https://github.com/llvm/llvm-project/pull/190354 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
