github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp --
clang/test/CIR/CodeGen/partial-array-cleanup.cpp
clang/lib/CIR/CodeGen/CIRGenClass.cpp clang/lib/CIR/Dialect/IR/CIRDialect.cpp
clang/lib/CIR/Dialect/Transforms/LoweringPrepare.cpp
clang/test/CIR/CodeGen/array-ctor.cpp --diff_from_common_commit
``````````
:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/clang/lib/CIR/CodeGen/CIRGenClass.cpp
b/clang/lib/CIR/CodeGen/CIRGenClass.cpp
index 02e074200..748d450d6 100644
--- a/clang/lib/CIR/CodeGen/CIRGenClass.cpp
+++ b/clang/lib/CIR/CodeGen/CIRGenClass.cpp
@@ -784,8 +784,7 @@ void CIRGenFunction::emitCXXAggrConstructorCall(
RunCleanupsScope scope(*this);
bool needsPartialArrayCleanup =
- getLangOpts().Exceptions &&
- !ctor->getParent()->hasTrivialDestructor();
+ getLangOpts().Exceptions && !ctor->getParent()->hasTrivialDestructor();
auto emitCtorBody = [&](mlir::OpBuilder &b, mlir::Location l) {
mlir::BlockArgument arg =
diff --git a/clang/lib/CIR/Dialect/IR/CIRDialect.cpp
b/clang/lib/CIR/Dialect/IR/CIRDialect.cpp
index 3e020e52e..61f61466c 100644
--- a/clang/lib/CIR/Dialect/IR/CIRDialect.cpp
+++ b/clang/lib/CIR/Dialect/IR/CIRDialect.cpp
@@ -419,8 +419,7 @@ LogicalResult cir::ArrayCtor::verify() {
if (!partialDtor.empty()) {
mlir::Block &dtorBlock = partialDtor.front();
if (dtorBlock.getNumArguments() != 1)
- return emitOpError(
- "partial_dtor must have exactly one block argument");
+ return emitOpError("partial_dtor must have exactly one block argument");
auto bodyArgTy = getBody().front().getArgument(0).getType();
if (dtorBlock.getArgument(0).getType() != bodyArgTy)
diff --git a/clang/lib/CIR/Dialect/Transforms/LoweringPrepare.cpp
b/clang/lib/CIR/Dialect/Transforms/LoweringPrepare.cpp
index f5ab40678..5e00e0c8f 100644
--- a/clang/lib/CIR/Dialect/Transforms/LoweringPrepare.cpp
+++ b/clang/lib/CIR/Dialect/Transforms/LoweringPrepare.cpp
@@ -1435,7 +1435,7 @@ static void
lowerArrayDtorCtorIntoLoop(cir::CIRBaseBuilderTy &builder,
// Clone the region body (ctor/dtor call and any setup ops like per-element
// zero-init) into the loop, remapping the block argument to the current
- // element pointer.
+ // element pointer.
auto cloneRegionBodyInto = [&](mlir::Block *srcBlock,
mlir::Value replacement) {
mlir::IRMapping map;
@@ -1495,8 +1495,8 @@ static void
lowerArrayDtorCtorIntoLoop(cir::CIRBaseBuilderTy &builder,
/*cleanupBuilder=*/
[&](mlir::OpBuilder &b, mlir::Location loc) {
auto cur = cir::LoadOp::create(b, loc, eltTy, tmpAddr);
- auto cmp = cir::CmpOp::create(builder, loc, cir::CmpOpKind::ne,
- cur, begin);
+ auto cmp =
+ cir::CmpOp::create(builder, loc, cir::CmpOpKind::ne, cur, begin);
cir::IfOp::create(
builder, loc, cmp, /*withElseRegion=*/false,
[&](mlir::OpBuilder &b, mlir::Location loc) {
@@ -1504,20 +1504,18 @@ static void
lowerArrayDtorCtorIntoLoop(cir::CIRBaseBuilderTy &builder,
loc,
/*condBuilder=*/
[&](mlir::OpBuilder &b, mlir::Location loc) {
- auto el =
- cir::LoadOp::create(b, loc, eltTy, tmpAddr);
+ auto el = cir::LoadOp::create(b, loc, eltTy, tmpAddr);
auto neq = cir::CmpOp::create(
builder, loc, cir::CmpOpKind::ne, el, begin);
builder.createCondition(neq);
},
/*bodyBuilder=*/
[&](mlir::OpBuilder &b, mlir::Location loc) {
- auto el =
- cir::LoadOp::create(b, loc, eltTy, tmpAddr);
+ auto el = cir::LoadOp::create(b, loc, eltTy, tmpAddr);
mlir::Value negOne =
builder.getSignedInt(loc, -1, sizeTypeSize);
- auto prev = cir::PtrStrideOp::create(
- builder, loc, eltTy, el, negOne);
+ auto prev = cir::PtrStrideOp::create(builder, loc, eltTy,
+ el, negOne);
builder.createStore(loc, prev, tmpAddr);
cloneRegionBodyInto(partialDtorBlock, prev);
builder.createYield(loc);
``````````
</details>
https://github.com/llvm/llvm-project/pull/190834
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits