================
@@ -132,24 +133,31 @@ ModuleManager::AddModuleResult ModuleManager::addModule(
 
   std::optional<ModuleFileKey> FileKey = FileName.makeKey(FileMgr);
   if (!FileKey) {
-    ErrorStr = "module file not found";
-    return Missing;
+    Result.K = AddModuleResult::Missing;
+    return Result;
   }
 
-  // Check whether we already loaded this module, before
+  // Check whether we already loaded this module before.
+  // Note: `isModuleFileOutOfDate` and `checkSignature` are mutally exclusive 
in
----------------
qiongsiwu wrote:

Nit: probably a typo? `mutally` -> `mutually`. 

https://github.com/llvm/llvm-project/pull/190203
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to