https://github.com/azmat-y updated https://github.com/llvm/llvm-project/pull/164019
>From 9afde00b345a05f3b3cfc9d345780ac9abb1ba71 Mon Sep 17 00:00:00 2001 From: Azmat Yusuf <[email protected]> Date: Sat, 18 Oct 2025 02:29:06 +0530 Subject: [PATCH] [Clang] Handle ?: operator in fold expression --- clang/lib/Sema/SemaExpr.cpp | 3 +++ clang/lib/Sema/SemaTemplateVariadic.cpp | 2 +- clang/test/SemaCXX/fold_expr_typo.cpp | 5 +++++ 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/clang/lib/Sema/SemaExpr.cpp b/clang/lib/Sema/SemaExpr.cpp index 9fd8c6a0a5451..c447e77dc804e 100644 --- a/clang/lib/Sema/SemaExpr.cpp +++ b/clang/lib/Sema/SemaExpr.cpp @@ -9239,6 +9239,9 @@ ExprResult Sema::ActOnConditionalOp(SourceLocation QuestionLoc, commonExpr = MatExpr.get(); } + if (commonExpr->getDependence() & ExprDependence::UnexpandedPack) + return ExprError(); + opaqueValue = new (Context) OpaqueValueExpr(commonExpr->getExprLoc(), commonExpr->getType(), commonExpr->getValueKind(), diff --git a/clang/lib/Sema/SemaTemplateVariadic.cpp b/clang/lib/Sema/SemaTemplateVariadic.cpp index 5b1aad3fa8470..057007383388b 100644 --- a/clang/lib/Sema/SemaTemplateVariadic.cpp +++ b/clang/lib/Sema/SemaTemplateVariadic.cpp @@ -1517,7 +1517,7 @@ static void CheckFoldOperand(Sema &S, Expr *E) { E = E->IgnoreImpCasts(); auto *OCE = dyn_cast<CXXOperatorCallExpr>(E); if ((OCE && OCE->isInfixBinaryOp()) || isa<BinaryOperator>(E) || - isa<AbstractConditionalOperator>(E)) { + isa<AbstractConditionalOperator>(E) || isa<RecoveryExpr>(E)) { S.Diag(E->getExprLoc(), diag::err_fold_expression_bad_operand) << E->getSourceRange() << FixItHint::CreateInsertion(E->getBeginLoc(), "(") diff --git a/clang/test/SemaCXX/fold_expr_typo.cpp b/clang/test/SemaCXX/fold_expr_typo.cpp index 0ef9c15b59476..2359d37740056 100644 --- a/clang/test/SemaCXX/fold_expr_typo.cpp +++ b/clang/test/SemaCXX/fold_expr_typo.cpp @@ -12,3 +12,8 @@ template <typename... U> struct A { foo<T>((... + static_cast<U>(1))); // expected-error {{expression contains unexpanded parameter pack 'T'}} } }; + +template <typename ... T> +void foo(T... Params) { + (Params ?: 1, ...); // expected-error {{expression not permitted as operand of fold expression}} +} _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
