Anastasia added a comment. Could you please explain a bit more why the alignment have to be put explicitly in the struct? I am just not very convinced this is general enough.
================ Comment at: lib/CodeGen/CGBlocks.cpp:314 assert(elementTypes.empty()); - elementTypes.push_back(CGM.VoidPtrTy); ---------------- Why removing this? ================ Comment at: test/CodeGenOpenCL/blocks.cl:17 int i; -// Checking for null instead of @_NSConcreteStackBlock symbol -// COMMON: store i8* null, i8** %block.isa + // COMMON-NOT: store i8* null, i8** %block.isa + // COMMON: %[[block_size:.*]] = getelementptr inbounds <{ i32, i32, i8 addrspace(4)*, i32 }>, <{ i32, i32, i8 addrspace(4)*, i32 }>* %block, i32 0, i32 0 ---------------- We don't need to check other fields too? https://reviews.llvm.org/D37822 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits