andrew.w.kaylor added a comment.

This is breaking buildbots for 32-bit targets because the offset in 'nullptr + 
int8_t_N' is being implicitly cast to an int.  That makes the sizeof(offset) == 
sizeof(ptr) check turn out differently than my tests were assuming.

I can get the buildbots green quickly by taking out parts of the tests, but I 
just talked to Erich Keane about this and we think the right way to fix this 
long term is to stop checking for sizeof(offset) == sizeof(ptr) in the code 
that identifies the idiom, since that check is of dubious value and would be 
difficult to always get to behave the way I intended.


Repository:
  rL LLVM

https://reviews.llvm.org/D37042



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to