xazax.hun added inline comments.
================ Comment at: lib/StaticAnalyzer/Checkers/PthreadLockChecker.cpp:594 + // it takes the mutex explicitly as an argument. + if (IsLibraryFunction && + std::find(ExplicitRegions.begin(), ExplicitRegions.end(), R) == ---------------- Wouldn't it be better to branch on `IsLibraryFunction` and in one branch iterate on `Regions` and in the other, iterate on `ExplicitRegions`? That would avoid the possible quadratic explosion when lots of explicit regions are invalidated. https://reviews.llvm.org/D37812 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
