================
@@ -763,6 +763,13 @@ static mlir::Value emitCommonNeonBuiltinExpr(
   }
 }
 
+static mlir::Value emitAArch64GetLaneBuiltinExpr(CIRGenBuilderTy &builder,
+                                                 mlir::Location loc,
+                                                 mlir::Value vec,
+                                                 mlir::Value lane) {
+  return cir::VecExtractOp::create(builder, loc, vec, lane);
----------------
banach-space wrote:

I don't see any value in creating a function that simply wraps a one-line 
`return` statement. Please inline this.

https://github.com/llvm/llvm-project/pull/186119
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to