https://github.com/AaronBallman commented:

Thank you for working on this! Please be sure to add a release note to 
`clang/docs/ReleaseNotes.rst` so users know about the new functionality. You 
should also add test coverage to `clang/test/AST` to ensure we get the expected 
dumping behavior. It's especially important to test how macro expansion 
behavior works because which file is involved can depend on whether we're 
looking at the macro spelling or the macro expansion. Other test cases that 
would be interesting would be a modules test where we're loading a module or 
PCH rather than including a regular source file.

https://github.com/llvm/llvm-project/pull/194266
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to