Serosh-commits wrote: > Adding this here as github didnt' let me add it at line #20227 of > `ExprConstant.cpp`. What does the `frexp` helper return for special values? > Also a check to ensure the mantissa is valid is missing.
ops i forget about this comment so basically as i can see the frexp helper for Inf and NaN, it returns the original value and sets the exponent to an internal status code and for finite values, it uses scalbn WHich guarantees the mantissa is in the standard [0.5, 1.0) range so i think manual checks aren't necessary let me know if you'd like me to explicitly set it to 0 to keep the results cleaner https://github.com/llvm/llvm-project/pull/194327 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
