andykaylor wrote: > > Why did you decide to opt for a new interface instead of just converting > > the CIR integers into mlir intrinsic integer types? > > I'm worried that with this verifier change, you could have valid OpenMP > > dialect code using types which are not supported by the translation to > > LLVM-IR > > When constructing CIR/OMP the types used are defined in CIR which we cannot > avoid when constructing the OMP operations since everything is happening at > once in the front-end. They do get lowered to the LLVM IR dialect before the > OMP operations are lowered to LLVM-IR, so there should be no issues regarding > unsupported types.
For OpenACC @erichkeane handled this by creating an `UnrealizedConversionCastOp` to be handled during lowering or some other dialect transform. https://github.com/llvm/llvm-project/pull/196363 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
