================
@@ -1,39 +1,16 @@
-// RUN: %check_clang_tidy %s
cppcoreguidelines-pro-type-member-init,hicpp-member-init,modernize-use-emplace,hicpp-use-emplace
%t
-
-namespace std {
-
-template <typename T>
-class vector {
-public:
- void push_back(const T &) {}
- void push_back(T &&) {}
-
- template <typename... Args>
- void emplace_back(Args &&... args){};
-};
-} // namespace std
+// RUN: %check_clang_tidy %s
cppcoreguidelines-use-default-member-init,modernize-use-default-member-init %t
class Foo {
public:
- Foo() : _num1(0)
- // CHECK-MESSAGES: warning: constructor does not initialize these fields:
_num2 [cppcoreguidelines-pro-type-member-init,hicpp-member-init]
- {
- _num1 = 10;
- }
+ Foo() : _num(0)
+ // CHECK-MESSAGES: warning: use default member initializer for '_num'
[cppcoreguidelines-use-default-member-init,modernize-use-default-member-init]
+ {}
int use_the_members() const {
- return _num1 + _num2;
+ return _num;
}
private:
- int _num1;
- int _num2;
- // CHECK-FIXES: int _num2{};
+ int _num;
+ // CHECK-FIXES: int _num{0};
};
-
-void should_use_emplace(std::vector<Foo> &v) {
- v.push_back(Foo());
- // CHECK-FIXES: v.emplace_back();
- // CHECK-MESSAGES: warning: use emplace_back instead of push_back
[hicpp-use-emplace,modernize-use-emplace]
-}
----------------
zeyi2 wrote:
I removed it because it uses `hicpp-use-emplace`, which would be removed later.
`modernize-use-emplace` only has one alias, so the test case no longer makes
sense here.
I'll try to add a new one here.
https://github.com/llvm/llvm-project/pull/196870
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
