https://github.com/banach-space commented:
This is not really my area of expertise and I've only managed to scan the `cmp` part. I checked against https://github.com/ARM-software/abi-aa/blob/main/cppabi32/cppabi32.rst#421representation-of-pointer-to-member-function and that LGTM, thanks! I am mildly concerned about mixing ARM (32-bit ISA) and AArch64 (64-bit ISA), but I suspect that's just inherited from the current implementation in Clang. I just wanted to highlight that there are two documents to follow: * 64-bit: https://github.com/ARM-software/abi-aa/blob/main/cppabi64/cppabi64.rst * 32-bit: https://github.com/ARM-software/abi-aa/tree/main/cppabi32 I am focusing on 64-bits. Btw, the test updates are a bit dense. There's no obvious way to avoid that, but I think that merging LLVM and OGCG lines would help. Just my 2p based on my experience with the intrinsics. https://github.com/llvm/llvm-project/pull/196592 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
