mstorsjo added inline comments.
================ Comment at: src/Unwind-sjlj.c:468 +#ifndef __APPLE__ +__thread struct _Unwind_FunctionContext *stack = NULL; ---------------- compnerd wrote: > I would prefer: > > #if !defined(__APPLE__) Sure, I can change that. ================ Comment at: src/Unwind-sjlj.c:469 +#ifndef __APPLE__ +__thread struct _Unwind_FunctionContext *stack = NULL; + ---------------- compnerd wrote: > Please make this `static`. Oh, indeed, yes, I'll change that. ================ Comment at: src/Unwind-sjlj.c:481 +#endif // !defined(__APPLE__) + #endif // defined(_LIBUNWIND_BUILD_SJLJ_APIS) ---------------- compnerd wrote: > Can't both of these also be static? No, since they're declared earlier as non-static. https://reviews.llvm.org/D38250 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
