https://github.com/AaronBallman commented:
I don't have strong opinions, but my weak opinion is that this seems pretty reasonable. Visitor pattern as an abstraction is basically compiler bread and butter. @Icohedron do you expect there will be more instances of the visitor used as HLSL implementation work continues? e.g., is this also in support of not adding more duplicate code in the near future? https://github.com/llvm/llvm-project/pull/194393 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
