malaperle added a comment.
Just a few quick comments.
================
Comment at: clangd/ClangdServer.cpp:295
+ assert(FileContents.Draft &&
+ "findDefinitions is called for non-added document");
+
----------------
findDocumentHighlights?
================
Comment at: clangd/ClangdServer.cpp:300
+ std::shared_ptr<CppFile> Resources = Units.getFile(File);
+ assert(Resources && "Calling findDefinitions on non-added file");
+
----------------
findDocumentHighlights?
================
Comment at: clangd/Protocol.cpp:782
+ llvm::raw_string_ostream(Result) << llvm::format(
+ R"({"range": %s, "number": %d})", Range::unparse(DH.range).c_str(),
DH.kind);
+ return Result;
----------------
number -> kind
https://reviews.llvm.org/D38425
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
