ilya-biryukov requested changes to this revision.
ilya-biryukov added a comment.
This revision now requires changes to proceed.
Some changes seem to be lost while merging with head.
================
Comment at: clangd/GlobalCompilationDatabase.cpp:75
+ auto CachedIt = CompilationDatabases.find(File);
+ std::string Error = "";
----------------
Maybe move `Error` closer to its usage (line 84: `auto CDB =
tooling::CompilationDatabase::loadFromDirectory ...`)?
================
Comment at: clangd/GlobalCompilationDatabase.cpp:90
+
+ // FIXME(ibiryukov): logging
+ // Output.log("Failed to find compilation database for " + Twine(File) +
----------------
Please remove this FIXME, it is already deleted in head.
================
Comment at: clangd/GlobalCompilationDatabase.cpp:97
- Logger.log("Failed to find compilation database for " + Twine(File) + "\n");
return nullptr;
----------------
Please restore this logging statement.
https://reviews.llvm.org/D37150
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
