================
@@ -54,14 +54,24 @@ inline bool IsLifetimeSafetyEnabled(Sema &S, const Decl *D) 
{
   return false;
 }
 
+inline StringRef formatExpr(const Expr *E) {
+  const Expr *PureExpr = E->IgnoreImpCasts();
----------------
usx95 wrote:

Instead of this, we should introduce a filter `bool 
shouldShowInAliasingChain(const Expr* CurExpr, const Expr* LastExpr)` and 
return `false` for `ParenCast` and `ImplicitCast`. This method can also be 
responsible for skipping if we have same source range as the `LastExpr`.

Currently we will print diagnostics multiple times for the inner expression.

https://github.com/llvm/llvm-project/pull/199345
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to