karolherbst wrote:

> spirv*-mesa-mesa3d are legal clang targets since 
> https://github.com/llvm/llvm-project/commit/3c6fe49a912adc1ffe174bdf3d547a8bd6826bee.

Please revert this or rename it to `spirv*--` to indicate it's a generic triple 
not tied to any implementation. We don't want any mesa specific triples or any 
implication that mesa is in any capacity a special target within clang.

I don't understand why we are now adding the concept of triples to SPIR-V and 
GPU runtimes. And I really really really don't want that we imply in any way 
that applications would need to provide their OpenCL runtime specific SPIR-V 
binaries. Please make no assumptions about how FMA is implemented, no 
assumptions about denorm behavior or anything, because we'll have to support 
the same spirv across varies hardware that have different implementation 
details.

And developers using clang to compile OpenCL C to SPIR-V should simply target 
OpenCL SPIR-V and nothing else. And use the same binary for every runtime.

We consume OpenCL/Vulkan SPIR-V. Not "mesa" SPIR-V. And we certainly don't want 
clang/llvm to apply any assumptions how our runtime behaves or requires beyond 
Extensions and Core language features.

https://github.com/llvm/llvm-project/pull/199618
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to