https://github.com/ahesham-arm updated https://github.com/llvm/llvm-project/pull/199974
>From cb38b33d26068f11b9583a73cf71f34f85df5f4c Mon Sep 17 00:00:00 2001 From: 3a2l <[email protected]> Date: Mon, 25 May 2026 18:09:36 +0100 Subject: [PATCH] [libclc] Fix zero signs in sincospi The generic sincospi helper applies the sign to both sine and cosine results. For exact-zero results, that can produce the wrong signed zero (+0/-0). Handle zero results explicitly after the normal reduction, preserving the input sign for sine, and positive sign for cosine. No change to non-zero results. Fixes sinpi/cospi signed-zero failures observed when running the OpenCL-CTS test: `test_bruteforce math_edge_cases`. Signed-off-by: Ahmed Hesham <[email protected]> --- libclc/clc/lib/generic/math/clc_sincospi.inc | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/libclc/clc/lib/generic/math/clc_sincospi.inc b/libclc/clc/lib/generic/math/clc_sincospi.inc index b8b50a6dfb012..4ec41fd78c84e 100644 --- a/libclc/clc/lib/generic/math/clc_sincospi.inc +++ b/libclc/clc/lib/generic/math/clc_sincospi.inc @@ -28,9 +28,18 @@ __clc_sincospi(__CLC_GENTYPE x, __private __CLC_GENTYPE *cos_out) { (__CLC_AS_S_GENTYPE(absx) ^ __CLC_AS_S_GENTYPE(x)); __CLC_GENTYPE c = odd ? -eval.sin : eval.cos; - *cos_out = + __CLC_GENTYPE sin = __CLC_AS_GENTYPE(sin_val); + __CLC_GENTYPE zero = __CLC_FP_LIT(0.0); + __CLC_S_GENTYPE signed_zero = + __CLC_AS_S_GENTYPE(x) & __CLC_GENTYPE_S_SIGNBIT; + + sin = __clc_select(sin, __CLC_AS_GENTYPE(signed_zero), + __CLC_CONVERT_S_GENTYPE(sin == zero)); + + __CLC_GENTYPE cos = __CLC_AS_GENTYPE(__CLC_CONVERT_S_GENTYPE(__CLC_AS_S_GENTYPE(c) ^ flip)); - return __CLC_AS_GENTYPE(sin_val); + *cos_out = __clc_select(cos, zero, __CLC_CONVERT_S_GENTYPE(cos == zero)); + return sin; } #define __CLC_SINCOSPI_DEF(addrspace) \ _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
