https://github.com/wangleiat approved this pull request.
> No issues overall, just one minor question: > > According to the > [LangRef,](https://llvm.org/docs/LangRef.html#function-attributes) the > default value of "stack-probe-size" is 4096: > > ``` > It takes one required integer value, which is 4096 by default. > ``` > > However, on LoongArch, the kernel page size is typically 16K. If we still use > 4K here, could that introduce unnecessary store instructions during stack > probing? I checked GCC as well, and it also uses 4096. This is just for discussion and does not block the landing. https://github.com/llvm/llvm-project/pull/195595 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
