I haven't looked at the patch. If this is guarded behind NOT LIBCXX_STANDALONE_BUILD checks, then it's probably fine.
> On Oct 4, 2017, at 21:36, Zachary Turner <ztur...@google.com> wrote: > > This doesn’t match up with what beanz said. While I assume Duncan is the > final word, can we get some confirmation from beanz that everyone is on the > same page? > > (Note that libcxx already uses some of LLVM’s cmake, but it’s behind some NOT > LIBCXX_STANDALONE_BUILD checks) > > Assuming the answer remains no, what can we do to make code sharing and reuse > easier? There’s clearly a need to reuse certain low level things and not keep > reinventing the wheel > On Wed, Oct 4, 2017 at 9:22 PM Duncan P. N. Exon Smith <dexonsm...@apple.com > <mailto:dexonsm...@apple.com>> wrote: > Thanks correct. > > > On Oct 4, 2017, at 18:49, Shoaib Meenai via Phabricator via cfe-commits > > <cfe-commits@lists.llvm.org <mailto:cfe-commits@lists.llvm.org>> wrote: > > > > smeenai added subscribers: zturner, rjmccall. > > smeenai added a comment. > > > > @rjmccall, this adds a libc++ build dependency on LLVM's cmake modules. > > There were some issues when @zturner had added a similar dependency for his > > work on lit. To confirm, Apple still cares about the use case of building > > libc++ without having any LLVM cmake modules available (either from source > > or from an LLVM installation), right? > > > > > > https://reviews.llvm.org/D31363 <https://reviews.llvm.org/D31363> > > > > > > > > _______________________________________________ > > cfe-commits mailing list > > cfe-commits@lists.llvm.org <mailto:cfe-commits@lists.llvm.org> > > http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits > > <http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits> >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
