jdoerfert wrote: > @alexey-bataev @jhuber6 I'm quite happy to hear that OpenMP AST dump tests > can be simply deleted. Does this cover both non-variant and variant tests? To > me it seem so, as > https://github.com/llvm/llvm-project/blob/61b5b08623e8457e28bce2984593632a9774be96/clang/test/OpenMP/begin_declare_variant_messages.c > feels quite comprehensive. > > If there is something useful in there, I can of course preserve that — just > let me know what it is.
Do *NOT* drop the variant tests. Even the AST ones. We could move the AST ones to codegen ones, but that just shifts the issue. We can make the AST checks much more relaxed though. We need to check that the right function was selected in the AST. For that we need the pseudo expression with the two calls, and the declarations, preferably with their return statements. All other fluff can go. Generally, do not drop message tests, they are the only error emmiting tests we have. https://github.com/llvm/llvm-project/pull/200077 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
