klimek added inline comments.
================
Comment at: clangd/ClangdServer.cpp:222
+
+ std::shared_ptr<PreambleData const> Preamble =
+ Resources->getPossiblyStalePreamble();
----------------
I think we use "const type" everywhere.
================
Comment at: clangd/ClangdServer.cpp:225
+ // A task that will be run asynchronously.
+ PackagedTask Task([=]() mutable { // 'mutable' to reassign Preamble variable.
+ if (!Preamble) {
----------------
It doesn't seem like we use Preamble anywhere else but in the lambda - so why
not get it in the lambda?
https://reviews.llvm.org/D38583
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
