================
@@ -54,14 +54,24 @@ inline bool IsLifetimeSafetyEnabled(Sema &S, const Decl *D) 
{
   return false;
 }
 
+inline StringRef formatExpr(const Expr *E) {
+  const Expr *PureExpr = E->IgnoreImpCasts();
----------------
usx95 wrote:

> My previous wording may not have been very accurate. What I meant is that 
> buildXXXChains cannot possibly make Sema diagnostics obtain the 
> ImplicitCastExpr and the following DeclRefExpr if it only does something as 
> simple as vector.push(SrcOrigin.getExpr()).

I do not follow. buildXXXChains is not responsible to do that. It should indeed 
be as simple as the `SrcOrigin.getExpr()`.

https://github.com/llvm/llvm-project/pull/199345
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to