szepet added a comment.
Hello Daniel!
It is a great feature to add, thanks for working on this!
I have just small comments (rather questions) on the code.
================
Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:155
+ Children.push(FuncBody);
+ while (!Children.empty()) {
+ const Stmt *Child = Children.top();
----------------
I think instead of this logic it would be better to use ConstStmtVisitor. In
this case it does quite the same thing in a (maybe?) more structured manner.
What do you think?
================
Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:168
+ VD->getStorageClass() == SC_Static &&
+ !VD->getType()->isPointerType()) {
+ Vars->insert(VD);
----------------
Is it possible that a type is an IntegerType and a PointerType at the same
time? If these are excluding cases then the check for !isPointer could be
removed.
Repository:
rL LLVM
https://reviews.llvm.org/D37897
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
