================
@@ -3285,27 +3290,49 @@ void PragmaCommentHandler::HandlePragma(Preprocessor
&PP,
return;
}
- // Verify that this is one of the 5 explicitly listed options.
+ // Verify that this is one of the 6 explicitly listed options.
IdentifierInfo *II = Tok.getIdentifierInfo();
PragmaMSCommentKind Kind =
- llvm::StringSwitch<PragmaMSCommentKind>(II->getName())
- .Case("linker", PCK_Linker)
- .Case("lib", PCK_Lib)
- .Case("compiler", PCK_Compiler)
- .Case("exestr", PCK_ExeStr)
- .Case("user", PCK_User)
- .Default(PCK_Unknown);
+ llvm::StringSwitch<PragmaMSCommentKind>(II->getName())
----------------
tonykuttai wrote:
@hubert-reinterpretcast @w2yehia
> @tonykuttai, to address @w2yehia's concern and still avoid the formatter
> check failure, you can
>
> * first land an NFC commit to update the formatting of this part of the code
> and
Merged [[NFC][clang] Format pragma comment kind
StringSwitch](https://github.com/llvm/llvm-project/pull/201754#top)
> * then land another NFC commit to add the previous NFC commit to the
> `.git-blame-ignore-revs` file in the repo.
[[NFC][clang] Add pragma comment formatting commit to blame ignore
list](https://github.com/llvm/llvm-project/pull/201765#top) up for review.
https://github.com/llvm/llvm-project/pull/178184
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits