ChuanqiXu9 wrote: > I'm not much familiar with clang AST Visitor testing, but is there any unit > or other tests for `clang/lib/AST`? If so, we better make test there as well. > Apart from this, lgtm with nit
It is fine generally if we have lit test. But I didn't notice the lit test doesn't belong to clang itself. Yeah, it is better to have a lit test under clang. We wrote unit tests less than lit test. https://github.com/llvm/llvm-project/pull/201481 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
